Skip to content

Add XML Clean Commands#908

Merged
edenhaus merged 6 commits into
DeebotUniverse:devfrom
nanomad:feature/xml-clean-commands
Apr 27, 2025
Merged

Add XML Clean Commands#908
edenhaus merged 6 commits into
DeebotUniverse:devfrom
nanomad:feature/xml-clean-commands

Conversation

@nanomad

@nanomad nanomad commented Apr 19, 2025

Copy link
Copy Markdown
Contributor

Depends on #907

@nanomad nanomad force-pushed the feature/xml-clean-commands branch from a466a81 to cff8edd Compare April 19, 2025 17:06
@codecov

codecov Bot commented Apr 19, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.78%. Comparing base (331360c) to head (de04f1b).
Report is 1 commits behind head on dev.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
deebot_client/commands/xml/clean.py 97.22% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #908      +/-   ##
==========================================
+ Coverage   92.75%   92.78%   +0.03%     
==========================================
  Files         124      125       +1     
  Lines        4787     4824      +37     
  Branches      303      309       +6     
==========================================
+ Hits         4440     4476      +36     
  Misses        285      285              
- Partials       62       63       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nanomad nanomad force-pushed the feature/xml-clean-commands branch from cff8edd to 8eb6136 Compare April 19, 2025 17:16
@codspeed-hq

codspeed-hq Bot commented Apr 19, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #908 will not alter performance

Comparing nanomad:feature/xml-clean-commands (de04f1b) with dev (331360c)

Summary

✅ 6 untouched benchmarks

@nanomad nanomad force-pushed the feature/xml-clean-commands branch from 5e68343 to 1dffae2 Compare April 20, 2025 00:29
@nanomad nanomad force-pushed the feature/xml-clean-commands branch 2 times, most recently from cf14938 to 281f102 Compare April 22, 2025 11:12
@nanomad nanomad marked this pull request as ready for review April 22, 2025 11:14

@edenhaus edenhaus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please solve the merge conflicts

@edenhaus edenhaus added the pr: new-feature PR, which adds a new feature label Apr 25, 2025
@nanomad nanomad force-pushed the feature/xml-clean-commands branch from 281f102 to 2be7cc6 Compare April 26, 2025 10:00
@nanomad nanomad requested a review from edenhaus April 26, 2025 10:05
@nanomad

nanomad commented Apr 26, 2025

Copy link
Copy Markdown
Contributor Author

@edenhaus Rebased

@edenhaus edenhaus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nanomad 👍

@edenhaus edenhaus enabled auto-merge (squash) April 27, 2025 16:10
@edenhaus edenhaus merged commit 1465b5c into DeebotUniverse:dev Apr 27, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: new-feature PR, which adds a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants